ci: build Core before inspecting downloaded themes - #5482
Conversation
Summary: - rebuild Core in pr-visual after dependency installation - let downloaded theme artifacts resolve their @astryxdesign/core dist imports - avoid repeating the full workspace build Test Plan: - reproduced ERR_MODULE_NOT_FOUND with downloaded-style theme dist and absent Core dist - pnpm -F @astryxdesign/core build - imported packages/themes/butter/dist/source.mjs successfully after the Core build - pnpm exec prettier --check .github/workflows/ci.yml - parsed workflow and verified Core build runs before the visual gate
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR No new or modified components detected. Bundle Size SummaryNo component packages changed. Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
|
It looks like #5481 is the better fix, and it has now merged. Both PRs address the same missing Core I think this PR can close as superseded by #5481. |
Summary
@astryxdesign/coreinpr-visualafter dependency installation@astryxdesign/core/dist/*importsWhy
#5477 began shipping built theme artifacts to
pr-visual, but those artifacts import Core's consumer-facingdistfiles. The downstream job starts from a fresh checkout, installs dependencies without building packages, and therefore still fails before taking a screenshot:This currently affects #5466 and #5475.
Test plan
packages/core/distand reproduced the exact import failure frompackages/themes/butter/dist/source.mjspnpm -F @astryxdesign/core buildpnpm exec prettier --check .github/workflows/ci.yml