Skip to content

fix(Dialog): address responsive review feedback - #5367

Open
rubyycheung wants to merge 1 commit into
mainfrom
fix/dialog-review-followup
Open

fix(Dialog): address responsive review feedback#5367
rubyycheung wants to merge 1 commit into
mainfrom
fix/dialog-review-followup

Conversation

@rubyycheung

Copy link
Copy Markdown
Contributor

Draft follow-up to #5352 after Cindy merged it without these review nits applied.

Addresses Cindy's inline review discussions:

Validation:

  • Astryx bootstrap: help, docs, docs principles --dense, docs tokens --dense, docs theme --dense, component --list, template --list, component Dialog --dense
  • pnpm vitest run packages/core/src/Dialog/Dialog.test.tsx packages/core/src/Dialog/DialogHeader.test.tsx packages/core/src/AlertDialog/AlertDialog.test.tsx
  • pnpm -F @astryxdesign/core typecheck
  • pnpm -F @astryxdesign/core typecheck:docs
  • pnpm -F @astryxdesign/core build
  • pnpm -F @astryxdesign/docsite generate && pnpm -F @astryxdesign/docsite typecheck after building theme packages used by docsite
  • pnpm exec prettier --check packages/core/src/Dialog/Dialog.tsx packages/core/src/Dialog/Dialog.test.tsx .changeset/dialog-responsive-interaction.md
  • pnpm exec eslint packages/core/src/Dialog/Dialog.tsx packages/core/src/Dialog/Dialog.test.tsx
  • pnpm check:repo

@vercel

vercel Bot commented Aug 23, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
astryx Ready Ready Preview Aug 23, 2026 9:12pm

Request Review

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Aug 23, 2026
@github-actions github-actions Bot added the needs:code-review High-risk change (new package/component/API) — needs human code review before merge label Aug 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

PR Analysis Report

📚 Storybook Preview

View Storybook for this PR
GitHub Pages may take up to a minute to hydrate after deploy.

🧪 Sandbox Preview

View Sandbox for this PR
GitHub Pages may take up to a minute to hydrate after deploy.

Modified Components

Dialog (@astryxdesign/core) · View in Storybook
Metric Before After Delta
Bundle Size (ESM) N/A N/A N/A
Lines of Code N/A 688 -
Complexity N/A Very High (81) -

Bundle Size Summary

Package Size (ESM) Size (CJS) Gzipped
@astryxdesign/core N/A 4.8KB 1.2KB

Accessibility Audit

Status: No accessibility violations detected.


Generated by PR Enrichment workflow | Storybook | Sandbox | View full report

github-actions Bot added a commit that referenced this pull request Aug 23, 2026
@rubyycheung
rubyycheung marked this pull request as ready for review August 23, 2026 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot. needs:code-review High-risk change (new package/component/API) — needs human code review before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant