Silence many info logs in unit tests #3224
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This diff: * Silences info logs about custom trials being attached, which comes from manually creating experiments for optimization traces. * Allows Scheduler's logging level to be customized, and changes the default level from INFO to WARNING for computing baseline values only. I didn't change it overall since knowing how many trials have run is useful for understanding what is happening. I lowered the level for unit tests. * Silences warnings about poor model fit (model fit is checked in every `gen` call). Reviewed By: Balandat Differential Revision: D67797711
Summary: I'm not sure if there is a nice way to do this in tests by default. This mostly silences logs about trials being generated and completed. Differential Revision: D67815243
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67815243 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3224 +/- ##
=======================================
Coverage 95.88% 95.88%
=======================================
Files 513 513
Lines 51681 51697 +16
=======================================
+ Hits 49553 49569 +16
Misses 2128 2128 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in 7484965. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: I'm not sure if there is a nice way to do this in tests by default. This mostly silences logs about trials being generated and completed.
Differential Revision: D67815243