Fix trial_as_task for pending points #3222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: ## The Change If trial indices are not in the level dict, we set TRIAL_PARAM to the max in level_dict, which is the max observed trial index. We may choose to replace this with the target trial in a follow up. We then have to ensure the trial_index is not set to something it shouldn't be in `TrialAsTask.untransform_observation_features()` and `ChoiceToNumericChoice.untransform_observation_features()`, which seem to be from generated points and come out as floats. I'm less certain about why this is. There may be another error in the modeling stack, but in the meantime it would block candidate generation. ## The Promlem Reviewed By: lena-kashtelyan Differential Revision: D67766937
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67766937 |
|
This pull request has been merged in f26f931. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The Change
If trial indices are not in the level dict, we set TRIAL_PARAM to the max in level_dict, which is the max observed trial index. We may choose to replace this with the target trial in a follow up.
We then have to ensure the trial_index is not set to something it shouldn't be in
TrialAsTask.untransform_observation_features()andChoiceToNumericChoice.untransform_observation_features(), which seem to be from generated points and come out as floats. I'm less certain about why this is. There may be another error in the modeling stack, but in the meantime it would block candidate generation.The Promlem
Reviewed By: lena-kashtelyan
Differential Revision: D67766937