Type annotations -- mark some parameters as immutable; copy immutable arguments that may be mutated #3213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… arguments that may be mutated Summary: Context: I ran into some of these while adding a benchmark and decided to fix the annotations rather than adding pyre-ignores This PR: * Marks `BenchmarkProblem.status_quo_params` as immutable * Marks `SurrogateTestFunction.outcome_names` as immutable * Copies parameters when they are passed to `ObservationFeatures` so they will not be mutated by transforms * Marks `parameters` passed to `Arm` as immutable * Marks parameters as immutalbe in various search space functions * Removes unused ignores Differential Revision: D67624124
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67624124 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3213 +/- ##
=======================================
Coverage 95.87% 95.87%
=======================================
Files 513 513
Lines 51636 51636
=======================================
Hits 49505 49505
Misses 2131 2131 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in 6607582. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context:
I ran into some of these while adding a benchmark and decided to fix the annotations rather than adding pyre-ignores
This PR:
BenchmarkProblem.status_quo_paramsas immutableSurrogateTestFunction.outcome_namesas immutableObservationFeaturesso they will not be mutated by transformsparameterspassed toArmas immutableDifferential Revision: D67624124