Merged
Conversation
Signed-off-by: Christoph Plett <plett@faccts.de>
stgeo
requested changes
Apr 7, 2026
Contributor
stgeo
left a comment
There was a problem hiding this comment.
Thanks - looks much better now!
In addition to the inline comments, I noticed two things:
- I got a PyTorch/CUDA warning:
venv-aimnet2/lib/python3.12/site-packages/torch/cuda/__init__.py:371: UserWarning: Found GPU0 NVIDIA RTX A500 Laptop GPU which is of compute capability (CC) 8.6.
The following list shows the CCs this version of PyTorch was built for and the hardware CCs it supports:
Please follow the instructions at https://pytorch.org/get-started/locally/ to install a PyTorch release that supports one of these CUDA versions: 12.6, 12.8, 13.0
_warn_unsupported_code(d, device_cc, code_ccs)
It goes away with -d cuda. Not sure how to make it not complain. In any case, it's just a warning and it works correctly on both GPU and CPU.
- The test references need to be updated for the new default model:
======================================================================
FAIL: test_H2O_engrad (__main__.Aimnet2Tests.test_H2O_engrad)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/tests/aimnet2/test_aiment2_standalone.py", line 58, in test_H2O_engrad
self.assertAlmostEqual(energy, expected_energy, places=9)
AssertionError: -76.4768264497 != -76.47682538331 within 9 places (1.0663899985274838e-06 difference)
======================================================================
FAIL: test_OH_anion_eng_grad (__main__.Aimnet2Tests.test_OH_anion_eng_grad)
----------------------------------------------------------------------
Traceback (most recent call last):
File "tests/aimnet2/test_aiment2_standalone.py", line 93, in test_OH_anion_eng_grad
self.assertAlmostEqual(energy, expected_energy, places=9)
AssertionError: -75.82629740302 != -75.82629634884 within 9 places (1.0541800037344728e-06 difference)
======================================================================
FAIL: test_OH_rad_eng_grad (__main__.Aimnet2Tests.test_OH_rad_eng_grad)
----------------------------------------------------------------------
Traceback (most recent call last):
File "tests/aimnet2/test_aiment2_standalone.py", line 128, in test_OH_rad_eng_grad
self.assertAlmostEqual(energy, expected_energy, places=7)
AssertionError: -75.68258800204 != -75.68258695326 within 7 places (1.0487800068403885e-06 difference)
Signed-off-by: Christoph Plett <plett@faccts.de>
Signed-off-by: Christoph Plett <plett@faccts.de>
Signed-off-by: Christoph Plett <plett@faccts.de>
Contributor
Author
|
@stgeo regarding the warning: It seems to me that the cuda version you have installed does not match your GPU. So this is probably a warning the user might want to have. Otherwise, we could also filter it with The tests are updated now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the AIMNet2 integration to use the currently maintained package (aimnetcentral), enabling access to all supported models.
Closes #32.