Skip to content

Conversation

@ncave
Copy link
Collaborator

@ncave ncave commented Oct 15, 2025

  • Updated FCS to latest (commit cfda5f6)
  • Updated TFM to .NET 9.0 (to avoid package warnings)
  • FCS built with .NET 10.0.100

@ncave ncave marked this pull request as draft October 15, 2025 16:27
@ncave ncave force-pushed the net10rc2 branch 2 times, most recently from 663cabd to 91f2c24 Compare October 16, 2025 04:36
@ncave ncave marked this pull request as ready for review October 16, 2025 04:46
@ncave ncave force-pushed the net10rc2 branch 2 times, most recently from 93f94f3 to b561fc4 Compare November 11, 2025 18:59
@ncave ncave requested a review from MangelMaxime November 11, 2025 19:06
@ncave
Copy link
Collaborator Author

ncave commented Nov 11, 2025

@MangelMaxime This is ready for merging, but perhaps we want to create another alpha release before merging this, to not mix it with all the other changes.

@MangelMaxime
Copy link
Member

@ncave Sorry I missed your notification.

I think we should wait for the crackers to be fixed #4257 and #4252 and released.

Then, we can include this PR in the main branch and see how it goes. I should have some time available tomorrow to look at the PR, and see if we can easily use a local version of the buildalyzer using NuGet.config or something like that.

@ncave ncave force-pushed the net10rc2 branch 4 times, most recently from 45465fb to e33fa40 Compare November 21, 2025 19:03
@MangelMaxime
Copy link
Member

@ncave I think we are now ready to merge this PR.

  • Should we also update the global.json from .NET 9 or .NET 10?
  • Should we also update the fable-metadata dlls?

@ncave
Copy link
Collaborator Author

ncave commented Nov 25, 2025

@MangelMaxime

Should we also update the global.json from .NET 9 or .NET 10?

Perhaps, sure. But it's not directly related to this PR.
What we can try though is perhaps try again the Fable CLI with TFM 8.0, now that the Buildalyzer is fixed.
The TFM change is a separate commit so you can easily reverse it if needed, but I'm not sure if the issue is related though.

Should we also update the fable-metadata dlls?

No, that would be a different PR, for the repl. There are still some runtime issues with it that need looking into.

@MangelMaxime
Copy link
Member

What we can try though is perhaps try again the Fable CLI with TFM 8.0, now that the Buildalyzer is fixed.
The TFM change is a separate commit so you can easily reverse it if needed, but I'm not sure if the issue is related though.

Sorry, I am not sure to understand this part. Do you means to revert to <TargetFramework>net8.0</TargetFramework> in Fable.CLI.fsproj? Or should we target net10.0?

@ncave
Copy link
Collaborator Author

ncave commented Nov 26, 2025

@MangelMaxime Never mind, I thought that the Buildalyzer fix can help somehow, but it doesn't.

For Fable CLI, we can use TFM 9.0 (as this PR already does), or go to TFM 10.0 if you prefer, your choice.

If we stay with TFM 8.0, it kind of works, but we get build warnings for package version clashing at build time.
The issue stems from latest FCS picking up some v9.0.0 dependencies that clash with TFM 8.0:

".NETStandard,Version=v2.0/": {
     "FSharp.Compiler.Service/43.11.200-dev": {
        "dependencies": {
          "FSharp.Core": "10.0.200-dev",
          "FSharp.DependencyManager.Nuget": "10.0.200-dev",
          "System.Buffers": "4.6.0",
          "System.Collections.Immutable": "9.0.0",
          "System.Diagnostics.DiagnosticSource": "9.0.0",
          "System.Memory": "4.6.0",
          "System.Reflection.Emit": "4.7.0",
          "System.Reflection.Metadata": "9.0.0",
          "System.Runtime.CompilerServices.Unsafe": "6.1.0"
        },

@MangelMaxime
Copy link
Member

@ncave Yes, the Buildalyzer fix was only to fix the resolution of the source files.

For Fable CLI, we can use TFM 9.0 (as this PR already does), or go to TFM 10.0 if you prefer, your choice.

I think we already had a similar discussion in the past, but I can't remember if we decided to go with the latest version available or the latest LTS version. I think we should go with the lastest LTS as this is probably aligned with how often people update their own projects.

@ncave
Copy link
Collaborator Author

ncave commented Nov 27, 2025

@MangelMaxime

I think we should go with the latest LTS

Sure, we can switch to TFM 10.0 (LTS) in a separate PR. I can make one after this gets merged.

@MangelMaxime MangelMaxime merged commit e1db944 into fable-compiler:main Nov 27, 2025
59 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants