-
Notifications
You must be signed in to change notification settings - Fork 314
Update FCS to latest #4237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FCS to latest #4237
Conversation
663cabd to
91f2c24
Compare
93f94f3 to
b561fc4
Compare
|
@MangelMaxime This is ready for merging, but perhaps we want to create another alpha release before merging this, to not mix it with all the other changes. |
|
@ncave Sorry I missed your notification. I think we should wait for the crackers to be fixed #4257 and #4252 and released. Then, we can include this PR in the main branch and see how it goes. I should have some time available tomorrow to look at the PR, and see if we can easily use a local version of the buildalyzer using |
45465fb to
e33fa40
Compare
|
@ncave I think we are now ready to merge this PR.
|
Perhaps, sure. But it's not directly related to this PR.
No, that would be a different PR, for the repl. There are still some runtime issues with it that need looking into. |
Sorry, I am not sure to understand this part. Do you means to revert to |
|
@MangelMaxime Never mind, I thought that the Buildalyzer fix can help somehow, but it doesn't. For Fable CLI, we can use TFM 9.0 (as this PR already does), or go to TFM 10.0 if you prefer, your choice. If we stay with TFM 8.0, it kind of works, but we get build warnings for package version clashing at build time. |
|
@ncave Yes, the Buildalyzer fix was only to fix the resolution of the source files.
I think we already had a similar discussion in the past, but I can't remember if we decided to go with the latest version available or the latest LTS version. I think we should go with the lastest LTS as this is probably aligned with how often people update their own projects. |
Sure, we can switch to TFM 10.0 (LTS) in a separate PR. I can make one after this gets merged. |
Uh oh!
There was an error while loading. Please reload this page.