Skip to content

Conversation

@julianwachholz
Copy link
Contributor

Describe your changes
Extends the query selector to also exclude links in modal popups that change the current selection of objects. This relates mostly to modals for raw_id_fields.

Related issue
Previously reported in #420

Links for pagination were fixed, however the same modal may also contain links that should not open a new modal:

  • date_hierarchy
    image

  • all objects link in search results ("%(count)d total")
    image

  • "Clear all filters" and "Show counts" links on the filters on the right
    image

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have added tests for the proposed changes.
  • I have run the tests and there are not errors.

@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.44%. Comparing base (9fcce87) to head (bc17113).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #462   +/-   ##
=======================================
  Coverage   97.44%   97.44%           
=======================================
  Files          40       40           
  Lines         431      431           
=======================================
  Hits          420      420           
  Misses         11       11           
Flag Coverage Δ
unittests 97.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant