forked from chocolate-doom/chocolate-doom
-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heretic: Adding Translucency Option #1251
Merged
fabiangreffrath
merged 26 commits into
fabiangreffrath:master
from
Noseey:Heretic_Translucency_Option
Jan 2, 2025
+304
−102
Merged
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
41de092
Heretic: Adding Translucency Option - not functionally yet
Noseey f2ebddc
Heretic: Adding certain sprites to be translucent and disable item/pr…
Noseey 88b613f
Heretic: Adding further translucency effects.
Noseey 5b4926e
Heretic: Dirty Translucent Goldwand firing.
Noseey 43d2b48
Heretic: Translucency gun flash Goldwand
Noseey c29bf51
Heretic: Translucency gun flash Blaster, Hellrod
Noseey 0cb6f26
Heretic: Reconstructing maxlight when loading to align with Doom.
Noseey 65c4275
Heretic: Translucency gun flash Gauntlet, PhoenixRod
Noseey ae7bafc
Heretic: Restructured Translucent Weapon Fire evaluation.
Noseey cfcf484
Heretic: Translucency conditions and selection changed
Noseey feca92a
Heretic: Restructured Translucent Weapon Fire evaluation. (2nd)
Noseey d7f93db
Heretic: Translucency Option cleanup
Noseey fdef0dd
Merge branch 'fabiangreffrath:master' into Heretic_Translucency_Option
Noseey 359a359
Heretic: Changed Translucency for various things
Noseey 5e9aeb7
Merge branch 'Heretic_Translucency_Option' of https://github.com/Nose…
Noseey df9dae1
Heretic: Add Miscmissle Flag directly to MT_POD
Noseey 7159024
Heretic: Translucency Option fixing whitespaces, adding comments and …
Noseey 65f7469
Heretic: Weapon Translucency considering Invisibility Powerup
Noseey facde61
Heretic: Undo Translucency for dying Mummyleaders.
Noseey dafa64b
Revert "Heretic: Reconstructing maxlight when loading to align with D…
Noseey 94f4d1f
Heretic: Gauntlets no longer considered for weapon sprite translucency.
Noseey a7d2127
Heretic: Moved Translucency offsets to r_things.c
Noseey ae33ec6
Heretic: Fixing Whitespaces in info.h
Noseey 16e15f8
Heretic: Renamed translucency option for weapon flashes.
Noseey b974d88
Heretic: Removed MISCMISSILE Flag
Noseey 94f29f4
Heretic: Reworked y-offets for translucency
Noseey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Heretic: Changed Translucency for various things
- added/removed some translucent effects. - make goopods translucent upon explosion. - make leadermummy translucent upon facing enemy for ranged-attack.
commit 359a359ad8443f8261ab0cfcd4896ce85aa48fca
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tagged effects with MF_MISCMISSILE since some of them were neither MF_NOGRAVITY nor MF_MISSLE, and I still felt they should be translucent. If we stay with the current foreseen options, I think the flag and this whole condition might not be needed and I will remove or rework them. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Frankly, I'd prefer if we could get away without a second flag. But if it makes things easier, that'd be alright as well. But please add some elaborate comments if you decide to go that way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The flag is now removed and the condition reworked.