Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support of vitest benchmark #99

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

zkulbeda
Copy link
Contributor

@zkulbeda zkulbeda commented Aug 13, 2023

This separated pr is required to merge into main branch for testing github actions workflow in next coming pr #100. I just copied one of the tests from typescript-runtime-type-benchmark just for demo purposes.

Is benchmarks folder in ./library/src good place for storing benchmarks files?

@netlify
Copy link

netlify bot commented Aug 13, 2023

Deploy Preview for valibot canceled.

Name Link
🔨 Latest commit 8baa0c0
🔍 Latest deploy log https://app.netlify.com/sites/valibot/deploys/64e338b66ce73800080afda3

@fabian-hiller
Copy link
Owner

Thank you very much! The next few days I have to focus on my bachelor thesis. As soon as I find time, I'll get back to you.

@fabian-hiller fabian-hiller self-assigned this Aug 14, 2023
@fabian-hiller fabian-hiller added enhancement New feature or request github GitHub related changes labels Aug 14, 2023
@zkulbeda zkulbeda marked this pull request as ready for review August 15, 2023 18:00
@fabian-hiller
Copy link
Owner

Do you have any idea how we can make the result comparable to the latest version of Valibot, so we can see if changes have a positive or negative impact on the performance?

@fabian-hiller
Copy link
Owner

We could add the latest version of Valibot as a dev dependency and run the benchmark for both to have a comparison of the codebase to the latest Valibot version.

@zkulbeda
Copy link
Contributor Author

That's great idea for local testing without pull request! But I should research if adding dev dependency can make a conflict with existing package name or add alias to dependency to avoid collision.

@zkulbeda
Copy link
Contributor Author

Hi, @fabian-hiller, I added valibot dependency and now it's possible to compare current and latest perfomance in tests. Can you check it?

@fabian-hiller
Copy link
Owner

Yes, I will try to check it in the next few days.

@fabian-hiller
Copy link
Owner

Sorry for not coming back to this, but other things had a higher priority. I am also not sure if we really need it, since the basic structure of the library is set and changes will most likely not have a major impact on performance. It is still useful, but other things have a higher priority for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request github GitHub related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants