Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add object related documentations #357

Merged
merged 9 commits into from
Jan 16, 2024
Merged

docs: add object related documentations #357

merged 9 commits into from
Jan 16, 2024

Conversation

kazizi55
Copy link
Contributor

@kazizi55 kazizi55 commented Jan 8, 2024 •
edited
Loading

Implemented object related docs as discussed in #287

@kazizi55
Copy link
Contributor Author

kazizi55 commented Jan 8, 2024

@fabian-hiller
I modified Property.tsx a little bit without breaking changes.
Plz let me know what you think 🙏

  1. To express WithQuestionMarks's intersection type, I modified Property.tsx (d71f4dc).

  2. To express RequiredKeys's object index access, I modified Property.tsx (814f2e3)

@kazizi55
Copy link
Contributor Author

kazizi55 commented Jan 8, 2024

I convert this PR to draft, because I haven't written the example of object 🙏
After finishing writing the example, I'll open this PR.

@kazizi55 kazizi55 marked this pull request as draft January 8, 2024 06:52
@kazizi55 kazizi55 marked this pull request as ready for review January 8, 2024 13:58
@fabian-hiller fabian-hiller self-assigned this Jan 8, 2024
@fabian-hiller fabian-hiller added the documentation Improvements or additions to documentation label Jan 8, 2024
@fabian-hiller
Copy link
Owner

Thank you for this PR! I will review it later today or in the next few days.

@fabian-hiller
Copy link
Owner

I will merge this PR later.

@fabian-hiller fabian-hiller merged commit 0c03ce1 into fabian-hiller:main Jan 16, 2024
1 check passed
@fabian-hiller fabian-hiller mentioned this pull request Jan 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fabian-hiller fabian-hiller

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kazizi55 @fabian-hiller