Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: EAN validation #320

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

ariskemper
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Dec 25, 2023

‼️ Deploy request for valibot rejected.

Name Link
🔨 Latest commit 7584c96

@fabian-hiller fabian-hiller self-assigned this Dec 25, 2023
@fabian-hiller fabian-hiller added the enhancement New feature or request label Dec 25, 2023
@ariskemper ariskemper changed the title feat: add EAN validation feat: EAN validation Dec 26, 2023
@ariskemper
Copy link
Contributor Author

@fabian-hiller should i add docs to open validation PRs and we merge it after?

@fabian-hiller
Copy link
Owner

Yes, please add the docs to the PRs. Especially when we reach v1, it is important that each PR updates the docs as well, so that everything is properly documented.

@fabian-hiller
Copy link
Owner

Unfortunately, due to our rewrite a few months ago, this PR is no longer up to date with our source code. I still plan to add this action, but other things have a higher priority for me at the moment. If you or anyone else in the community is interested in creating a new PR, that would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants