-
-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ISIN validation #298
Conversation
ariskemper
commented
Dec 15, 2023
•
edited
Loading
edited
- Validation for ISIN ( Internatinal Securities Identification Number ) with format validation and use of luhn algorithm
|
Name | Link |
---|---|
🔨 Latest commit | 1c39b51 |
Thank you so much for all the work you put into Valibot! It means a lot to me and it provides a great value to all Valibot users. If you have time during the winter break, I would love to get to know you in a video call. |
Sure we could have a call and discuss how we could improve the library. |
In case you use Discord, feel free to send me (fabianhiller) a friend request. |
Can you check your code against the formatting requirements and this code of validator.js to see if it covers every case? |
@fabian-hiller i refactor and moved isISIN to validation. I have done some research and most common use is mod10 in validation of ISIN. Mod 10 is simpler to implement and faster to compute, which is often sufficient for shorter sequences like the 12-character ISIN. |
Thanks! Will have a look at it next week. |
b997a0f
to
6d0cde4
Compare
Unfortunately, due to our rewrite a few months ago, this PR is no longer up to date with our source code. I still plan to add this action, but other things have a higher priority for me at the moment. If you or anyone else in the community is interested in creating a new PR, that would be great. |
41ae798
to
4a7ee57
Compare
7a97dd0
to
b5f7f4d
Compare
I will close this PR. However, I will keep it in mind when adding this action in the future. |