Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add contributor section #252

Conversation

kazizi55
Copy link
Contributor

Implements: #220 (comment)

Copy link

netlify bot commented Nov 14, 2023

Deploy Preview for valibot ready!

Name Link
🔨 Latest commit b9de6b8
🔍 Latest deploy log https://app.netlify.com/sites/valibot/deploys/656fccbbf7cc7a00088eaf6c
😎 Deploy Preview https://deploy-preview-252--valibot.netlify.app/404
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kazizi55
Copy link
Contributor Author

This is how contributor section looks:

スクリーンショット 2023-11-14 9 36 53

@@ -0,0 +1,116 @@
import { fetch } from 'undici';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

badge
Copied from Qwik doc, and modified a littile bit (e.g. changing directory path and dealing with github personal token)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kazizi55 kazizi55 marked this pull request as ready for review November 14, 2023 00:45
@fabian-hiller
Copy link
Owner

Thank you very much! I will review it after the next version of Valibot is released.

@fabian-hiller fabian-hiller self-assigned this Nov 19, 2023
@fabian-hiller fabian-hiller added documentation Improvements or additions to documentation priority This has priority labels Nov 19, 2023
Copy link
Owner

@fabian-hiller fabian-hiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again for your contributions!

@fabian-hiller fabian-hiller merged commit ae178eb into fabian-hiller:main Dec 6, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation priority This has priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants