feat: 인증 기능 구현 #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fallback은 따로 구현해주지 않아서 NoFallbackAvailableException.class를 기준으로 예외처리를 해주었습니다.
f-lab-nolan
reviewed
Apr 11, 2025
| } | ||
|
|
||
| private void validateStoredRefreshToken(final String email, final String requestToken) { | ||
| String storedToken = redisTokenRepository.findByEmail(email) |
Collaborator
There was a problem hiding this comment.
String storedToken = redisTokenRepository.findByEmail(email)
.map(s -> {
if (!s.equals(requestToken)) {
throw new BusinessException(ErrorCode.INVALID_TOKEN);
}
return s;
})
.orElseThrow(() -> new BusinessException(ErrorCode.NOT_FOUND_TOKEN));
Collaborator
There was a problem hiding this comment.
String storedToken = redisTokenRepository.findByEmail(email)
.filter(s -> s.equals(requestToken))
.orElseThrow(() -> new BusinessException(ErrorCode. INVALID_TOKEN));
f-lab-nolan
reviewed
Apr 11, 2025
| final String refreshToken = tokenProvider.createRefreshToken(email, userType, userStatus); | ||
|
|
||
| redisTokenRepository.save(email, refreshToken); | ||
| return Token.of(accessToken, refreshToken); |
Collaborator
There was a problem hiding this comment.
new Token(accessToken, refreshToken);
f-lab-nolan
reviewed
Apr 11, 2025
| .parseClaimsJws(token); | ||
|
|
||
| }catch (final JwtException | IllegalArgumentException e) { | ||
| return false; |
Collaborator
There was a problem hiding this comment.
logger.error(e.getMessage(), e)
f-lab-nolan
reviewed
Apr 11, 2025
| import jakarta.validation.constraints.NotBlank; | ||
|
|
||
| public record LoginRequestDto( | ||
Collaborator
There was a problem hiding this comment.
email검사 심플하게 하는 경우
- 사용 불가 특수문자 있나 확인.
- @ 하나만 잇는지 확인.
- @ 다음 문자열에 . 이 하나 혹은 두개만 있는지 확인 -> @ 다른 문자열에 . 이 있는지 확인
- @ 도메인에서 사용하지 못하는 특수문자 있는지 확인
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
추가 사항
관련 이슈