Skip to content

Conversation

@ljdongz
Copy link
Collaborator

@ljdongz ljdongz commented Apr 14, 2025

#️⃣ 연관된 이슈

📝 작업 내용

LinkMetadata 모듈의 코드를 구현했습니다.

🎨 스크린샷

기능 스크린샷
결과

@ljdongz ljdongz requested a review from f-lab-barry April 14, 2025 06:45
@ljdongz ljdongz self-assigned this Apr 14, 2025
@ljdongz ljdongz linked an issue Apr 14, 2025 that may be closed by this pull request
@ljdongz ljdongz changed the base branch from develop to Chore/#1 April 14, 2025 13:17
public let url: String
public let title: String?
public let icon: Data?
public let image: Data?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thumbnail


public init() {}

public func fetchMetadata(urlString: String) async throws -> LinkMetadata {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

result 타입 사용해도 좋을 것 같아요

Copy link

@f-lab-barry f-lab-barry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

개선 후 멘션해주시면 한번 더 볼게요~

Base automatically changed from Chore/#1 to develop April 14, 2025 14:45
@sonarqubecloud
Copy link

Copy link

@f-lab-barry f-lab-barry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ljdongz ljdongz merged commit 4f846e0 into develop Apr 28, 2025
2 checks passed
@ljdongz ljdongz deleted the feature/#5 branch April 28, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] LinkMetadataKit 모듈 구현

3 participants