[Refactor] 전체적인 코드 리팩토링 #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
ljdongz
commented
May 18, 2025
Comment on lines
+32
to
+40
|
|
||
| @propertyWrapper | ||
| public struct Dependency<T> { | ||
| public let wrappedValue: T | ||
|
|
||
| public init() { | ||
| self.wrappedValue = DIContainer.shared.resolve() | ||
| } | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
Reducer에서 의존성을 쉽게 불러오기 위한 프로퍼티 래퍼입니다.
@Dependency private var useCase: UseCase
Comment on lines
13
to
+19
| public struct LinkMetadataProviderImpl: LinkMetadataProvider { | ||
| private let metadataProvider = LPMetadataProvider() | ||
|
|
||
| public init() {} | ||
|
|
||
| public func fetchMetadata(urlString: String) async -> Result<LinkMetadata, LinkMetadataError> { | ||
| let metadataProvider = LPMetadataProvider() | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
fetchMetadata(urlString:)을 두번 연속 호출하게 되면서 발생할 수 있는 LinkMetadataError.concurrentFetchNotAllowed 에러를 방지하기 위해 메서드 내에서 LPMetadataProvider 객체를 생성해서 사용하도록 수정했습니다.
Comment on lines
+56
to
+59
|
|
||
| enum AuthError: Error { | ||
| case unauthenticated | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
인증되지 않은 상태에서 허용되지 않은 접근(ex. 모든 링크, 폴더 가져오기 ...)을 할 경우 발생시킬 에러 타입을 정의했습니다
Collaborator
Author
There was a problem hiding this comment.
Firestore와 Storage 경로를 구분했습니다.
| import Foundation | ||
|
|
||
| struct Link: Hashable { | ||
| struct WebLink: Hashable { |
Collaborator
Author
There was a problem hiding this comment.
View에서 웹페이지를 띄우기 위해 사용되는 View Component인 Link와 네이밍이 겹쳐 수정했습니다.
f-lab-barry
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
📝 작업 내용
아래 작업을 수행했습니다.
🎨 스크린샷
💬 추가 설명