[Feature] macOS 메인 화면 구현 #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
f-lab-barry
reviewed
Apr 14, 2025
Mark-In/Sources/MainView.swift
Outdated
| .foregroundStyle(.blue) | ||
|
|
||
| Button(action: { | ||
|
|
f-lab-barry
reviewed
Apr 14, 2025
| import SwiftUI | ||
| import DesignSystem | ||
|
|
||
| private struct ViewConstants { |
There was a problem hiding this comment.
const 정의할 때 struct와 enum 으로 할 수 있음
enum이 더 성능적으로 유리한데 그 이유가 뭘까요?
f-lab-barry
reviewed
Apr 14, 2025
|
|
||
| struct LinkListView: View { | ||
| let cellWidth: CGFloat = ViewConstants.cellWidth | ||
| let cellHeight = ViewConstants.cellHeight |
f-lab-barry
reviewed
Apr 14, 2025
Comment on lines
24
to
29
| let width = geometry.size.width | ||
| let numberOfColumns = max( | ||
| Int((width + spacing) / (cellWidth + spacing)), | ||
| 1 | ||
| ) | ||
|
|
There was a problem hiding this comment.
클로저 내부의 응집도나, solid 원칙 (단일책임원칙 등)을 잘 준수하는 코드가 맞을지 고민해보면서 리팩토링 해보면 좋을 것 같아요~
f-lab-barry
approved these changes
Apr 14, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
close [Feature] macOS 메인 화면 구현 #3
[Chore] 모듈 분리 및 빌드 환경 분리 #1 작업에서 이어서 진행했습니다.
📝 작업 내용
macOS에서 표현될 메인 화면을 틀만 잡아서 간단하게 구현했습니다.
🎨 스크린샷
💬 추가 설명
기본 컴포넌트로 초기 계획했던 디자인(상단 툴바)을 구현하는 데 어려움이 있어 현재는 일단 기본 컴포넌트로 간단하게 구현해보았고,
후에 커스텀으로 변경할지, 기본 컴포넌트로 진행할 지 고민할 예정입니다.