Skip to content

Conversation

@ljdongz
Copy link
Collaborator

@ljdongz ljdongz commented May 4, 2025

#️⃣ 연관된 이슈

📝 작업 내용

구글 로그인을 구현했습니다.

🎨 스크린샷

기능 스크린샷
GIF

💬 추가 설명

@ljdongz ljdongz requested a review from f-lab-barry May 4, 2025 12:29
@ljdongz ljdongz self-assigned this May 4, 2025
@ljdongz ljdongz linked an issue May 5, 2025 that may be closed by this pull request
Comment on lines +29 to +31
.onOpenURL { url in
GIDSignIn.sharedInstance.handle(url)
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2개 이상일 때 체크


// TODO: 에러 처리 필요
case .googleLoginButtonTapped:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

메서드 분리하면 좋을 것 같아요

}

SignInButton(provider: .google) {
// TODO: 구글 로그인 로직

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

주석 제거 필요

Base automatically changed from feature/#24 to develop May 6, 2025 16:50
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 6, 2025

@ljdongz ljdongz merged commit 40eb399 into develop May 6, 2025
2 checks passed
@ljdongz ljdongz deleted the feature/#26 branch May 6, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] 구글 로그인 구현

3 participants