fix: typecheck and fix errors in glob.py#210
Closed
ezyang wants to merge 1 commit into
Closed
Conversation
ezyang
added a commit
that referenced
this pull request
Mar 25, 2025
Typecheck codemcp/glob.py and fix errors. Typecheck ONLY this file (typecheck command takes a filename as argument). ```git-revs 3ffd8f2 (Base revision) 2f6e403 Add missing List[str] type annotation for result variable and import Any from typing d29a90c Add List[str] type annotation for items variable 4b4ea7f Add List[str] type annotation for processed_items variable 3ada72b Add List[str] type annotation for result variable in find function 164fff5 Replace unused dirnames variable with underscore to avoid warning HEAD Remove unused Any import ``` codemcp-id: 218-fix-typecheck-and-fix-errors-in-glob-py ghstack-source-id: 0f83054 Pull-Request-resolved: #210
This was referenced Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Typecheck codemcp/glob.py and fix errors. Typecheck ONLY this file (typecheck command takes a filename as argument).
codemcp-id: 218-fix-typecheck-and-fix-errors-in-glob-py