Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pydantic v1 and v2 support #213

Merged
merged 15 commits into from
Sep 6, 2023
Merged

Pydantic v1 and v2 support #213

merged 15 commits into from
Sep 6, 2023

Conversation

eyurtsev
Copy link
Owner

@eyurtsev eyurtsev commented Sep 5, 2023 •
edited
Loading

Make kor pydantic v1 and v2 compatible.

Additional changes:

  • No more validation on node ids -- makes it easier to use node ids in other languages (e.g., chinese)
  • Add testing to CI to test with both v1 and v2

Not fully implemented:

  • Support for serialization via parse_obj

@eyurtsev
Copy link
Owner Author

eyurtsev commented Sep 5, 2023

#206

@eyurtsev eyurtsev merged commit f5fac29 into main Sep 6, 2023
5 checks passed
@eyurtsev eyurtsev deleted the eugene/pydantic_support branch September 6, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eyurtsev