Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load schema from JSON #178

Merged

Conversation

BorisWilhelms
Copy link
Contributor

This PR makes the schema loadable from JSON via Object.parse_raw.

PR includes feature, tests and documentation

Link to Issue #177

@eyurtsev
Copy link
Owner

Hi @BorisWilhelms thanks for the contribution and the tests. The code looks good to me -- one question I wanted to ask is if you found a way to create the serialized format from the object or is only de-serialization supported?

@eyurtsev eyurtsev merged commit 94d6bcb into eyurtsev:main Jun 27, 2023
5 checks passed
@BorisWilhelms BorisWilhelms deleted the feature/schema-loadble-from-json branch June 28, 2023 07:38
@BorisWilhelms
Copy link
Contributor Author

Hi @eyurtsev, currently only deserialization is supported. For serialization the $type property must be somehow present/filled. Will check the next couple of days, if there is a nice way to do that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants