Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color-spantrace to monorepo #105

Merged
merged 47 commits into from
Oct 10, 2023
Merged

Add color-spantrace to monorepo #105

merged 47 commits into from
Oct 10, 2023

Conversation

pksunkara
Copy link
Contributor

@pksunkara pksunkara commented Sep 20, 2023

Other than the commits that we picked from that repo using subtree (can be verified by the subtree commit), I only added the following commit.

yaahc and others added 30 commits April 24, 2020 16:40
* dedupe ansi_term dep

* bump version for release
* init

* Add missing test data

* Implement requested changes

* Rename test/styles.rs and tests/data/style_control.txt

* bump version on owo-colors and run rustfmt

* update control to include source lines

* tweek the documentation a little

* bump version and prep for release

* (cargo-release) start next development iteration 0.1.6-alpha.0

Co-authored-by: d4h0 <[email protected]>
Co-authored-by: Jane Lusby <[email protected]>
* ignore all io errors while resolving source files

* prep for release
Update tracing-error (and tracing-subscriber)
@pksunkara pksunkara changed the title Add color-spantrace to monoreo Add color-spantrace to monorepo Sep 20, 2023
@pksunkara pksunkara requested a review from a team September 20, 2023 08:59
…0805af8'

git-subtree-dir: color-spantrace
git-subtree-mainline: a443fd4
git-subtree-split: 1a52aac
@pksunkara
Copy link
Contributor Author

@ten3roberts Would you be willing to take a look at the failing test? I haven't gotten a chance to dig into the source code yet.

@ten3roberts
Copy link
Contributor

@ten3roberts Would you be willing to take a look at the failing test? I haven't gotten a chance to dig into the source code yet.

Sure, I'll see what I can do 😊

Copy link
Contributor

@ten3roberts ten3roberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we fix the deprecated lints before merging?

What do you think would be easier, this or a separate PR?

@pksunkara
Copy link
Contributor Author

Probably a separate PR for streamlining the lint rules later across all crates.

Copy link
Contributor

@ten3roberts ten3roberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@pksunkara pksunkara merged commit 0b24ae5 into master Oct 10, 2023
29 checks passed
@pksunkara pksunkara deleted the color-spantrace branch October 10, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants