Skip to content

chore: clean up vendor dir after vendor_pkgs() #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

albersonmiranda
Copy link
Contributor

This PR adds a clean up step at the end of vendoring process to remove src/rust/vendor dir.

Closes #452

@CGMossa
Copy link
Member

CGMossa commented Jun 11, 2025

I like it. I have come to like the presence of the vendor directory even in usual development.
Could you add this folder to the rbuildignore and the gitignore too?

Copy link

codecov bot commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.69%. Comparing base (5d3ae4a) to head (215ec1a).

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
R/cran-compliance.R 84.41% <100.00%> (+0.63%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@albersonmiranda
Copy link
Contributor Author

Could you add this folder to the rbuildignore and the gitignore too?

@CGMossa use_extendr() already does it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up after vendor_pkgs()?
2 participants