-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add use_extendr_badge() #417
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realized I did not actually comment here, but created a pending review comment 🤦 .
@@ -217,6 +220,9 @@ use_extendr <- function(path = ".", | |||
usethis::use_build_ignore("src/Makevars.win") | |||
usethis::use_git_ignore("src/Makevars.win") | |||
|
|||
|
|||
use_extendr_badge() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you use it by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, as a point of encouragement. It does quite literally nothing other than print a message to the console. The hope is that users can add it to their package for a bit of flair and provide and indication that they're R package is rust powered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels like it defeats the purpose, a user still have to run use_extendr()
once. What's the point of a separate function? Perhaps it is better to show here an invite to run rextendr::use_extendr_badge()
?
Currently in draft status.