Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add use_extendr_badge() #417

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: add use_extendr_badge() #417

wants to merge 5 commits into from

Conversation

JosiahParry
Copy link
Contributor

Currently in draft status.

@JosiahParry JosiahParry changed the title feat: (draft) add use_extendr_badge() feat: add use_extendr_badge() Feb 25, 2025
@JosiahParry JosiahParry enabled auto-merge (squash) February 25, 2025 18:58
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.90%. Comparing base (88ec630) to head (9bd0985).

Files with missing lines Patch % Lines
R/badge.R 85.71% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
R/use_extendr.R 98.95% <100.00%> (+0.01%) ⬆️
R/badge.R 85.71% <85.71%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@Ilia-Kosenkov Ilia-Kosenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized I did not actually comment here, but created a pending review comment 🤦 .

@@ -217,6 +220,9 @@ use_extendr <- function(path = ".",
usethis::use_build_ignore("src/Makevars.win")
usethis::use_git_ignore("src/Makevars.win")


use_extendr_badge()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you use it by default?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, as a point of encouragement. It does quite literally nothing other than print a message to the console. The hope is that users can add it to their package for a bit of flair and provide and indication that they're R package is rust powered.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels like it defeats the purpose, a user still have to run use_extendr() once. What's the point of a separate function? Perhaps it is better to show here an invite to run rextendr::use_extendr_badge()?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants