yet another rebase! generic body parser #574
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 15, 2025
ctcpip
force-pushed
the
generic-again
branch
2 times, most recently
from
8715c66 to
3bb268b
Compare
|
As I commented there, can you please call out what was wrong in the original and previous rebase PR? I will review this, but since it changes many lines and I have now read two others supposedly doing the exact same thing I won't read this one again until we have a clear callout for what we all should be looking at specifically. |
squashed the following commits: Added support for external parsers to bodyParser.json() removed test dependency on json-bigint reworked doc to describe json parser() func better added parser() option and doc for .text() added parser() option and doc for .raw() added parser() option and doc for .urlencoded() cleanup to satisfy linter added generic parser converted json parser to use generic parser converted raw parser to use generic parser converted text parser to use generic parser converted urlencoded parser to use generic parser cleanup / fix linter warnings removed items from README added bodyParser.generic() getter cleanup / fix linter warnings fixed tests after rebase satisfying linter Ref'd genParser via the bodyparser getter to signal how third party parsers should import genParser' removed dep on object-assign, which didnt support node < 0.10 minor text cleanup 🔧 add debug script 🐛 fix object merging 🔥 clean up 💚 remove node < 4 from CI Co-authored-by: S Dellysse <[email protected]> Co-authored-by: ctcpip <[email protected]> Co-authored-by: Phillip9587 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersedes #524