Skip to content

fix: robust schema parsing in workflow validator #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MatrixNeoKozak wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: robust schema parsing in workflow validator #85

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions plugins/expo/skills/expo-cicd-workflows/scripts/validate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,15 @@ const SCHEMA_URL = 'https://api.expo.dev/v2/workflows/schema';

async function fetchSchema() {
const data = await fetchCached(SCHEMA_URL);
const body = JSON.parse(data);
return body.data;
try {
const body = JSON.parse(data);
if (!body || typeof body.data !== 'object') {
throw new Error('Invalid schema response structure');
}
return body.data;
} catch (e) {
throw new Error(`Failed to parse schema: ${e.message}`);
}
}

function createValidator(schema) {
Expand Down Expand Up @@ -57,9 +64,7 @@ if (import.meta.main) {
const files = args.filter((a) => !a.startsWith('-'));

if (files.length === 0 || args.includes('--help') || args.includes('-h')) {
console.log(`Usage: validate <workflow.yml> [workflow2.yml ...]

Validates EAS workflow YAML files against the official schema.`);
console.log(`Usage: validate <workflow.yml> [workflow2.yml ...]\n\nValidates EAS workflow YAML files against the official schema.`);
process.exit(files.length === 0 ? 1 : 0);
}

Expand Down