Skip to content

[eas-simulator] agent-device screenshot --scale, --max-size removed - #137

Merged
gwdp merged 2 commits into
mainfrom
gwdp/agent-device-screenshot-scale
Aug 14, 2026
Merged

gwdp merged 2 commits into
mainfrom
gwdp/agent-device-screenshot-scale

Conversation

@gwdp

@gwdp gwdp commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Why

agent-device PR #1617 adds a scale-only screenshot --scale knob and removes --max-size. Our controller reference told agents the opposite: that agent-device screenshots are "full-resolution with no scale knob."

How

  • Rewrote the agent-device screenshot note in references/controllers.md:
    • screenshot --scale <0.01–1> resizes both dimensions, 1 = full resolution.
    • Token-conscious default via AGENT_DEVICE_SCREENSHOT_SCALE / screenshotScale in config, overridden by an explicit --scale.
    • --max-size is removed and older calls are refused with migration guidance.
    • Added a remote-session caveat: the resize runs on the daemon, so a newer client against an older EAS session daemon can have --scale silently ignored.
  • Gated the whole thing on v0.20.6 as a single token, easy to bump if it ships as a different version.
  • Bumped the plugin version to 1.9.7.

Test Plan

  • Cross-check every claim against agent-device#1617's own doc changes: flag name, the 0.01–1 range, the env var / config key, and the --max-size removal

@gwdp
gwdp force-pushed the gwdp/agent-device-screenshot-scale branch from fb1f4df to 51eddf1 Compare August 12, 2026 04:58
@gwdp
gwdp requested a review from szdziedzic August 12, 2026 04:58
@gwdp
gwdp marked this pull request as ready for review August 12, 2026 04:58

@szdziedzic szdziedzic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

@gwdp
gwdp merged commit 0814f2c into main Aug 14, 2026
2 checks passed
@gwdp
gwdp deleted the gwdp/agent-device-screenshot-scale branch August 14, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants