[eas-simulator] agent-device screenshot --scale, --max-size removed - #137
Merged
Merged
Conversation
gwdp
force-pushed
the
gwdp/agent-device-screenshot-scale
branch
from
August 12, 2026 04:58
fb1f4df to
51eddf1
Compare
gwdp
marked this pull request as ready for review
August 12, 2026 04:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
agent-device PR #1617 adds a scale-only
screenshot --scaleknob and removes--max-size. Our controller reference told agents the opposite: that agent-device screenshots are "full-resolution with no scale knob."How
references/controllers.md:screenshot --scale <0.01–1>resizes both dimensions,1= full resolution.AGENT_DEVICE_SCREENSHOT_SCALE/screenshotScalein config, overridden by an explicit--scale.--max-sizeis removed and older calls are refused with migration guidance.--scalesilently ignored.v0.20.6as a single token, easy to bump if it ships as a different version.Test Plan
0.01–1range, the env var / config key, and the--max-sizeremoval