feat!: emit a dedicated metric event for count queries - #662
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #662 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 109 109
Lines 17755 17803 +48
Branches 934 935 +1
=========================================
+ Hits 17755 17803 +48
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
gwdp
marked this pull request as ready for review
July 22, 2026 22:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Count queries reported their result through the load event, so a
COUNT(*)returning 8k looked like we loaded 8k entities.How
Give counts their own event (
logDataManagerCountEvent) so the count number stops being read as entities loaded. Breaking:IEntityMetricsAdapterimplementers need to add the method; I'm happy to go for another path, non-breaking change if you prefer, but this felt more fundamentally correctTest Plan
CI. Updated the metrics unit test to check the counts route to the new event.