feat: accept array of parent entity classes in cascade deletion rule - #650
Merged
Conversation
…DeletionPrivacyPolicyRule
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #650 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 110 109 -1
Lines 17588 17755 +167
Branches 1515 919 -596
==========================================
+ Hits 17588 17755 +167
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
gwdp
marked this pull request as ready for review
July 9, 2026 23:41
wschurman
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
AllowIfInParentCascadeDeletionPrivacyPolicyRuleonly accepts a singleparentEntityClass, but sibling entity classes backed by the same table need separate rules for each. This adds up when you have entities that share a table but aren't in an inheritance chain.Thread: https://app.graphite.com/github/pr/expo/universe/28900#discussion-IC_kwDOAz9RTM8AAAABJd5cSg
How
parentEntityClassnow accepts a single class or an array. Backward compatible — single class works identically.Test Plan
New test cases for array form. Existing 740 tests pass.