-
Notifications
You must be signed in to change notification settings - Fork 897
feat(testset_generator): support error catching in generation process #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(testset_generator): support error catching in generation process #368
Conversation
191d9e4
to
3a62f75
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this PR looks good! Looping in @shahules786 for the final approval
Thanks @yuukidach for adding this PR :)
hey @yuukidach we are also working on refactoring the testset generator piece. I've shared the RFC here #380 and I would love to hear your feedback too. I can jump on a call and explain it more too if you want - let me know if you're interested :) |
LGTM |
Hey @yuukidach I must have sent this to you already but it is because we really mean it - Thank you so much for helping us improve ragas with your PR ❤️. Now since it's Christmas and all we wanted to send you a postcard and a couple of stickers as our way of saying thank you for your contribution. If you are interested could you shoot an email at [email protected] and I'll tell you more? Cheers 🙂 |
Thank you so much for your kind message! I'm delighted to have been able to contribute to improving ragas, and receiving your appreciation means a lot. I appreciate the offer of a postcard and stickers for Christmas, but I'm currently in another country, and I understand that it might be inconvenient for you to send them here. Nevertheless, I truly value your gesture, and knowing your goodwill has already made me happy. I had a quick look at the refactoring of test_generator, and it seems quite meaningful. I'm curious whether you've considered introducing the concept of an agent, such as autogen. It appears to be a trend in the future applications of llm and aligns well with your ideas. Wishing you a joyful Christmas season! |
@yuukidach I hadn't considered it previously but it is interesting. I'm curious as to the concepts you linked in that if you can share |
I am using Azure OpenAI API to generate testset. However, Azure's API is sensitive to content and can easily trigger the following returns:
The
finish_reason
iscontent_filter
and the content isNone
.When conducting
create_llm_result()
, because the content isNone
, an error will be raised.This error will interrupt the execution of the entire generation task. In fact, if such an error occurs, we can just skip it and moving on to generate another test item.