-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(metrics): avoid getting none in context_recall #355
fix(metrics): avoid getting none in context_recall #355
Conversation
Hi @yuukidach , thanks for the PR. This can be treated as a quick fix. IMO doing this might cause incorrect scores, Ideally on such edge cases score should be nan. Would you like to modify it? |
0cf3197
to
7032cd4
Compare
@shahules786 Thanks for reviewing. I‘ve modified the code as required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@shahules786 Hi, I just found out that CI failed during type check. These errors should have existed for some time and the CI configurations are not changed. Why did other relevant PRs not trigger this error before? I don't get it. |
It seems pyright released a new version yesterday. Fixed to 1.1.338 in |
Thank you @yuukidach I was wondering the same. |
Hey @yuukidach Cheers 🙂 |
Maybe this isssue #352 is talking about the same thing.