Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metrics): avoid getting none in context_recall #355

Merged
merged 4 commits into from
Dec 7, 2023

Conversation

yuukidach
Copy link
Contributor

Maybe this isssue #352 is talking about the same thing.

@yuukidach yuukidach changed the title fix(metrics): avoid to get none in context_recall fix(metrics): avoid getting none in context_recall Dec 5, 2023
@shahules786
Copy link
Member

Hi @yuukidach , thanks for the PR. This can be treated as a quick fix. IMO doing this might cause incorrect scores, Ideally on such edge cases score should be nan. Would you like to modify it?

@shahules786 shahules786 self-requested a review December 7, 2023 10:15
@yuukidach
Copy link
Contributor Author

@shahules786 Thanks for reviewing. I‘ve modified the code as required.

Copy link
Member

@shahules786 shahules786 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuukidach
Copy link
Contributor Author

@shahules786 Hi, I just found out that CI failed during type check. These errors should have existed for some time and the CI configurations are not changed. Why did other relevant PRs not trigger this error before? I don't get it.

@yuukidach
Copy link
Contributor Author

yuukidach commented Dec 7, 2023

@shahules786 Hi, I just found out that CI failed during type check. These errors should have existed for some time and the CI configurations are not changed. Why did other relevant PRs not trigger this error before? I don't get it.

It seems pyright released a new version yesterday. Fixed to 1.1.338 in requirements/dev.txt

@shahules786
Copy link
Member

Thank you @yuukidach I was wondering the same.

@shahules786 shahules786 merged commit af55f18 into explodinggradients:main Dec 7, 2023
14 checks passed
@yuukidach yuukidach deleted the fix/context_recall branch December 10, 2023 15:02
@jjmachan
Copy link
Member

Hey @yuukidach
Thank you so much for helping us improve ragas with your PR ❤️
Now since it's Christmas and all we wanted to send you a postcard and a couple of stickers as our way of saying thank you for your contribution. If you are interested could you shoot an email at [email protected] and I'll tell you more?

Cheers 🙂
Jithin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants