Skip to content

fix: correct noncommittal detection & filter empty questions in answer_relevancy #2343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: correct noncommittal detection & filter empty questions in answer_relevancy #2343

wants to merge 1 commit into from

Conversation

@anistark
Copy link
Contributor

@anistark anistark commented Oct 6, 2025

Issue Link / Problem Description

Changes Made

  • Changed np.all() back to np.any() to correctly detect when ANY answer is noncommittal
  • Added filtering of empty/whitespace questions before cosine similarity calculation to prevent NaN errors
  • Reordered logic to check noncommittal before empty questions

References

@anistark anistark marked this pull request as ready for review October 6, 2025 15:48
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Oct 6, 2025
@anistark anistark mentioned this pull request Oct 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahules786 shahules786 Awaiting requested review from shahules786

Assignees

No one assigned

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

why answer_relavancy getting nan and sometime get 0. why is that?

1 participant

@anistark