Migrate Faithfulness + dependent metrics #2325
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XXL
NirantK
requested changes
Sep 29, 2025
Comment on lines
18
to
19
| if t.TYPE_CHECKING: | ||
| from langchain_core.callbacks.base import Callbacks | ||
| pass |
| # DIRECT PROMPT TEMPLATES (No PydanticPrompt dependencies) | ||
| # ============================================================================ | ||
|
|
||
| CORRECTNESS_CLASSIFIER_PROMPT = """Given a ground truth and an answer statements, analyze each statement and classify them in one of the following categories: TP (true positive): statements that are present in answer that are also directly supported by the one or more statements in ground truth, FP (false positive): statements present in the answer but not directly supported by any statement in ground truth, FN (false negative): statements found in the ground truth but not present in answer. Each statement can only belong to one of the categories. Provide a reason for each classification. |
There was a problem hiding this comment.
These prompts should be in the "prompts" folder and not inline here
| ) | ||
| examples_text += "-----------------------------\n" | ||
|
|
||
| return f"""Decompose and break down each of the input sentences into one or more standalone statements. Each statement should be a standalone claim that can be independently verified. |
There was a problem hiding this comment.
Move the prompts to it's own director and use .format to fill in the templates or wrap in a function there
NirantK
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.