Skip to content

Metric with different parameter gives different score #1908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 8, 2025
Merged

Metric with different parameter gives different score #1908

merged 3 commits into from
Feb 8, 2025

Conversation

sahusiddharth
Copy link
Collaborator

@sahusiddharth sahusiddharth commented Feb 7, 2025 •
edited
Loading

fixes: #1907

jjmachan
jjmachan approved these changes Feb 8, 2025
View reviewed changes
Copy link
Member

@jjmachan jjmachan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was actually a very good implementation - feel free to merge it in 🙂

tip

put the PR discription as fixes: #1907 that will automatically close it when its done

@sahusiddharth sahusiddharth marked this pull request as ready for review February 8, 2025 02:38
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Feb 8, 2025
@sahusiddharth sahusiddharth merged commit 7c4997f into explodinggradients:main Feb 8, 2025
18 checks passed
@sahusiddharth sahusiddharth deleted the fix_metric_with_different_modes_gives_one_score branch February 11, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjmachan jjmachan jjmachan approved these changes

Assignees
No one assigned
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ragas evaluate method for the same metric with different parameters gives scores for only one metric
2 participants
@sahusiddharth @jjmachan