-
Notifications
You must be signed in to change notification settings - Fork 838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: translate instruction when adapting prompt #1529
feat: translate instruction when adapting prompt #1529
Conversation
Hey @Yunnglin Did you observe better results when translating both? We observed pretty good results with only translating a few shot examples. Another reason why we did not translate instruction was that time it introduces ambiguity. FOr example, let's say if the instruction was "Output False if a number greater than zero", this would also translate the word "False", which then causes issues while post-processing. |
Whether to translate the "instruction" could perhaps be made into an option. When I was generating a Chinese dataset, I found that some "extractor prompts" would lack examples, which led to the generated data not being very effective. |
This makes a ton of sense what we can do is take another argument for ragas/src/ragas/prompt/pydantic_prompt.py Lines 217 to 223 in 807c313
which converts it and it can be controlled through ragas/src/ragas/prompt/mixin.py Line 55 in 807c313
would be really helpful 🙂 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot.
When adapting prompts, both the examples and the corresponding instructions are important and need to be translated.