Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import of EvaluationDataset in testset_schema #1517

Closed
wants to merge 1 commit into from

Conversation

dlyz
Copy link
Contributor

@dlyz dlyz commented Oct 16, 2024

EvaluationDataset is imported only for type checking, but it is required in runtime for Testset.to_evaluation_dataset.

fixes #1515

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Oct 16, 2024
@dlyz
Copy link
Contributor Author

dlyz commented Oct 16, 2024

Seems like already fixed in #1516

@dlyz dlyz closed this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NameError: name 'EvaluationDataset' is not defined
1 participant