Skip to content

Conversation

dlyz
Copy link
Contributor

@dlyz dlyz commented Oct 16, 2024

EvaluationDataset is imported only for type checking, but it is required in runtime for Testset.to_evaluation_dataset.

fixes #1515

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Oct 16, 2024
@dlyz
Copy link
Contributor Author

dlyz commented Oct 16, 2024

Seems like already fixed in #1516

@dlyz dlyz closed this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NameError: name 'EvaluationDataset' is not defined
1 participant