Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update summarization calculation #1510

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

jCobbSK
Copy link
Contributor

@jCobbSK jCobbSK commented Oct 15, 2024

There is mismatch how coeff is used in docs vs actual computation.

Related code is in:

def _compute_score(self, scores) -> float:

Screenshot 2024-10-15 at 17 29 16

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Oct 15, 2024
@jjmachan jjmachan requested a review from shahules786 October 16, 2024 04:16
Copy link
Member

@shahules786 shahules786 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @jCobbSK thank buddy.

@shahules786 shahules786 merged commit efdda3f into explodinggradients:main Oct 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants