Merge remote-tracking branch 'upstream/main' into feature/fixEmbeddin…

…gCompatibility * upstream/main: fix: zero division error (#1530)
explodinggradients · Oct 18, 2024 · 5d7525b · 5d7525b
2 parents 56b4106 + 807c313
commit 5d7525b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/src/ragas/metrics/_factual_correctness.py b/src/ragas/metrics/_factual_correctness.py
@@ -253,12 +253,12 @@ async def _single_turn_ascore(
         false_negatives = sum(~response_reference)
 
         if self.mode == "precision":
-            score = true_positives / (true_positives + false_positives)
+            score = true_positives / (true_positives + false_positives + 1e-8)
         elif self.mode == "recall":
-            score = true_positives / (true_positives + false_negatives)
+            score = true_positives / (true_positives + false_negatives + 1e-8)
         else:
-            precision = true_positives / (true_positives + false_positives)
-            recall = true_positives / (true_positives + false_negatives)
+            precision = true_positives / (true_positives + false_positives + 1e-8)
+            recall = true_positives / (true_positives + false_negatives + 1e-8)
             score = 2 * (precision * recall) / (precision + recall + 1e-8)
 
         return np.round(score, 2)

diff --git a/src/ragas/testset/synthesizers/testset_schema.py b/src/ragas/testset/synthesizers/testset_schema.py
@@ -10,9 +10,6 @@
     SingleTurnSample,
 )
 
-if t.TYPE_CHECKING:
-    from ragas.dataset_schema import MultiTurnSample, SingleTurnSample
-
 
 class TestsetSample(BaseSample):
     """