refactor(eip): Refactor eip using egoscale v3 #642
Conversation
| // Comment for reviewer: | ||
| // Is there a way to get the created Elastic IP address or UUID ??? | ||
| // Listing all of them and comparing Addressfamily, Description,... doesn't really garantee uniquess | ||
| // TODO: Remove comment before merging | ||
| ElasticIP: "", | ||
| Zone: c.Zone, |
There was a problem hiding this comment.
yes you need to get the op after waiting and there is the op.Reference.ID check if reference not nil before using
There was a problem hiding this comment.
Is there a way to get the op from the decorateAsyncOperations ??
As this function is only returning an error if it happens ??!!
| // Message for reviewer: | ||
| // It always returns the list of all instances. Why ??? | ||
| // When no instance attached to Elastic IP, should returned an empty list | ||
| // When some instances attached to elastic IP, should returns only the attached instances | ||
| // Am I doing something wrong here ?? Is the ip-address parameter taking the Elastic IP into account ?? | ||
| // TODO: remove comment before merging | ||
| instances, err := client.ListInstances(ctx, v3.ListInstancesWithIPAddress(elasticIPID)) |
There was a problem hiding this comment.
I'll try to reproduce, thanks for reporting
There was a problem hiding this comment.
The list-instance option is still not working.
My guess is that in egoscale, the get parameter being added is ipAddress https://github.com/exoscale/egoscale/blob/v3.1.7/v3/operations.go#L9770 when on the openapi spec the query parameter should be ip-address.
Same for manager-id and manager-type
It is just a supposition.
Update the elastic ip using Egoscale v3.
Some stuff are not working yet: I put some comments in the code, you will see.
Checklist
(For exoscale contributors)
Testing
Create, delete, update ip,...