Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix instance/ipool key naming in json output #612

Merged

Conversation

kobajagi
Copy link
Contributor

@kobajagi kobajagi commented Jun 14, 2024

Description

Renames keys that did not match actual data:

  • template_id -> template;
  • zoneid -> zone.

These were present in both c instance show and c instance-pool show commands.

Checklist

(For exoscale contributors)

  • Changelog updated (under Unreleased block)
  • Testing

Testing

$ go run . c i show 1d1b482c-adcf-4928-acd9-fdffbe2d7c98 --output-format json | jq                                                                                        
{                                                                                                                                                                                            
  "id": "1d1b482c-adcf-4928-acd9-fdffbe2d7c98",                                                                                                                                              
  "name": "my-instance",                                                                                                                                                                
  "creation_date": "2024-06-14 15:09:06 +0000 UTC",                                                                                                                                          
  "instance_type": "standard.medium",                                                                                                                                                        
  "template": "sks-node-1.30.jammy",                                                                                                                                                         
  "zone": "ch-gva-2",                                                                                                                                                                        
  "anti_affinity_groups": [                                                                                                                                                                  
    "my-sks-anti-affinity-group"                                                                                                                                                             
  ],                                                                                                                                                                                         
  "deploy_target": "-",                                                                                                                                                                      
  "security_groups": [                                                                                                                                                                       
    "default",                                                                                                                                                                               
    "my-sks-security-group"                                                                                                                                                                  
  ],                                                                                                                                                                                         
  "private-instance": "No",                                                                                                                                                                  
  "private_networks": [],                                                                                                                                                                    
  "elastic_ips": [],
  "ip_address": "x.x.x.x",
  "ipv6_address": "-",
  "ssh_key": "-",
  "disk_size": "50 GiB",
  "state": "running",
  "labels": null,
  "reverse_dns": ""
}

@kobajagi kobajagi force-pushed the predrag/sc-95829/cli-c-i-get-json-output-showing-mismatch branch from f51fe38 to dfbd67e Compare June 19, 2024 15:06
@kobajagi kobajagi merged commit 2e48066 into master Jun 19, 2024
2 checks passed
@kobajagi kobajagi deleted the predrag/sc-95829/cli-c-i-get-json-output-showing-mismatch branch June 19, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants