Allow divide_dim to divide to non-literal expressions #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #628 +/- ##
=======================================
Coverage 87.00% 87.01%
=======================================
Files 94 94
Lines 21814 21838 +24
=======================================
+ Hits 18979 19002 +23
- Misses 2835 2836 +1 ☔ View full report in Codecov by Sentry. |
| @@ -1372,8 +1372,6 @@ def divide_dim(proc, alloc_cursor, dim_idx, quotient): | |||
| `x : R[n, 3, 4, m]` | |||
| `x[i, j / 4, j % 4, k] = ...` | |||
| """ | |||
| if quotient == 1: | |||
There was a problem hiding this comment.
Can you change the docstring above "This limited implementation of divide_dim requires that the dimension being divided is constant itself." ?
| @@ -728,25 +768,10 @@ def ceildiv(lhs, rhs): | |||
| elif tail_strategy in ["cut", "cut_and_guard"]: | |||
| outer_hi = szop("/", N, inner_hi) # floor div | |||
| elif tail_strategy == "perfect": | |||
| if not isinstance(N, LoopIR.Const): | |||
src/exo/LoopIR_scheduling.py
Outdated
| if isinstance(quot, int): | ||
| quot_int = quot | ||
| quot_ir = LoopIR.Const(quot, e.type, e.srcinfo) | ||
| elif isinstance(quot, LoopIR.expr): |
There was a problem hiding this comment.
This should be elif isinstance(quot, LoopIR.Const):
yamaguchi1024
requested changes
Apr 27, 2024
yamaguchi1024
approved these changes
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.