exercises(collatz-conjecture): example: refactor #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For this unsigned integer let's use `/` instead of `@divTrunc`,
and `%` instead of `@mod`.
The result is the same. From the Zig Language Reference [1]:
@divTrunc(numerator: T, denominator: T) T
Truncated division. Rounds toward zero.
For unsigned integers it is the same as `numerator / denominator`.
and [2]:
@mod(numerator: T, denominator: T) T
Modulus division. For unsigned integers this is the same as `numerator % denominator`.
That is, this commit does not change the instructions for the loop body,
which are [3]:
.LBB0_1:
mov rcx, rdi
shr rcx
test dil, 1
lea rdi, [rdi + 2*rdi + 1]
cmove rdi, rcx
inc rax
cmp rdi, 1
ja .LBB0_1
[1] https://ziglang.org/documentation/0.11.0/#divTrunc
[2] https://ziglang.org/documentation/0.11.0/#mod
[3] with Zig 0.12.0-dev.415+5af5d87ad and `-O ReleaseFast -mcpu raptorlake`
booniepepper
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this unsigned integer let's use:
/instead of@divTrunc%instead of@modThe result is the same. From the Zig Language Reference here:
and here:
That is, this commit does not change the instructions for the loop body, which are (with Zig 0.12.0-dev.415+5af5d87ad and
-O ReleaseFast -mcpu raptorlake):Refs: #313