Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exercises(robot-simulator): implement #558

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

ilmanzo
Copy link

@ilmanzo ilmanzo commented Jan 27, 2024

Reference to issue #555
Implement the missing robot-simulator exercise in Nim

Copy link

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Jan 27, 2024
@ee7 ee7 reopened this Jan 27, 2024
@ee7 ee7 self-assigned this Jan 27, 2024
@ilmanzo ilmanzo force-pushed the robot_simulator branch 2 times, most recently from 132889d to 66871ee Compare January 27, 2024 15:55
@ynfle
Copy link
Contributor

ynfle commented Feb 12, 2024

@ee7 @ilmanzo what is the state of this PR?

@ilmanzo
Copy link
Author

ilmanzo commented Feb 13, 2024

@ee7 @ilmanzo what is the state of this PR?

@ee7 did a lot of refactoring so now it seems pretty good at least for me :) Waiting for a final review I guess

@ee7 ee7 self-requested a review February 13, 2024 07:11
Copy link
Contributor

@ynfle ynfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great.

My only comment would be that perhaps the instructions could be a seq of an enum to ensure type safety at the caller level. Non blocking, though

@ynfle
Copy link
Contributor

ynfle commented Feb 13, 2024

I'm going to merge this in a couple of days if @ee7 is available for a review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants