Skip to content

Conversation

jagdish-15
Copy link
Member

@jagdish-15 jagdish-15 commented Aug 25, 2025

While running format.mjs for the other PRs that update the tests, I noticed it was also modifying unrelated files. I believe this PR will address that issue.

Do you know what might have caused it?
@SleeplessByte @Cool-Katt


Edit:
Now this check is failing here.
The command that caused these changes was:

corepack pnpm dlx cross-env node scripts/format.mjs

@SleeplessByte
Copy link
Member

Feels like a versioning issue. Let's see what our formatter here says.

/format

Copy link
Contributor

The "Format code" action has started running.

Copy link
Contributor

The "Format code" action has finished running.

Copy link
Contributor

For security reasons, /format does not trigger CI builds when the PR has been submitted from a fork. If checks were not passing due to code format, trigger a build to make the required checks pass, through one of the following ways:

  • Push an empty commit to this branch: git commit --allow-empty -m "Trigger builds".
  • Close and reopen the PR.
  • Push a regular commit to this branch.

@SleeplessByte
Copy link
Member

@jagdish-15 you probably want to check if the script reports 3.6.2 for the formatting!

@jagdish-15
Copy link
Member Author

$ corepack pnpm info prettier version
3.6.2

Yes, it does!

@SleeplessByte
Copy link
Member

Does that also show when you run corepack pnpm dlx cross-env node scripts/format.mjs?

Copy link
Contributor

The "Format code" action has started running.

Copy link
Contributor

The "Format code" action has finished running.

Copy link
Contributor

For security reasons, /format does not trigger CI builds when the PR has been submitted from a fork. If checks were not passing due to code format, trigger a build to make the required checks pass, through one of the following ways:

  • Push an empty commit to this branch: git commit --allow-empty -m "Trigger builds".
  • Close and reopen the PR.
  • Push a regular commit to this branch.

@jagdish-15
Copy link
Member Author

Does that also show when you run corepack pnpm dlx cross-env node scripts/format.mjs?

Yes, it changes the following files when run:

$ git status
On branch main
Your branch is up to date with 'origin/main'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   concepts/callbacks/about.md
        modified:   concepts/closures/about.md
        modified:   exercises/concept/amusement-park/.meta/design.md
        modified:   exercises/concept/bird-watcher/.meta/design.md
        modified:   exercises/concept/high-score-board/.meta/design.md
        modified:   exercises/concept/mixed-juices/.meta/design.md
        modified:   exercises/concept/ozans-playlist/.meta/design.md

no changes added to commit (use "git add" and/or "git commit -a")

And these files, upon running the /format here, go back to normal!

Copy link
Contributor

The "Format code" action has started running.

Copy link
Contributor

The "Format code" action has finished running.

Copy link
Contributor

For security reasons, /format does not trigger CI builds when the PR has been submitted from a fork. If checks were not passing due to code format, trigger a build to make the required checks pass, through one of the following ways:

  • Push an empty commit to this branch: git commit --allow-empty -m "Trigger builds".
  • Close and reopen the PR.
  • Push a regular commit to this branch.

@SleeplessByte
Copy link
Member

Still feels like a weird versioning difference. Imma toy around okay? Don't spend too much time on it.

@SleeplessByte
Copy link
Member

(Maybe related: #2740)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants