add error-handling exercise #2732
Conversation
This comment has been minimized.
This comment has been minimized.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
The contents are missing here, that's why the CI is failing!
There was a problem hiding this comment.
All the other exercises have a "stub" (initial code) that aids with implementation. Can you check the other concept exercises how we do that and add it here? It probably needs to define processString and merely raise an error to implement the function.
| console.log = jest.fn(); | ||
|
|
||
| try { | ||
| processString(''); | ||
| } catch { | ||
| /* | ||
| intentionally left empty, | ||
| I expext this call to throw, | ||
| but only care about verifying that the finally block is executed | ||
| and clean up message logged. | ||
| */ | ||
| } | ||
|
|
||
| expect(console.log).toHaveBeenCalledWith('Resource cleaned up'); |
There was a problem hiding this comment.
I don't think this will work with the Browser Test Runner, but the idea is not wrong. I can help come up with an easy alternative to fix this.
| @@ -0,0 +1,15 @@ | |||
| { | |||
| "authors": ["Obinna Obi-Akwari"], | |||
There was a problem hiding this comment.
This should be your GitHub user name, not what I’m guessing is your actual name.
There was a problem hiding this comment.
okay, i'll add it, thank you
…m/A-O-Emmanuel/javascript into implement-error-handling-exercise
There was a problem hiding this comment.
Generally, tests after the first one should be skipped by default. The online test runner will run all the tests, but that allows students working offline to practice TDD and solve tests one at a time.
You’re using it here, but the convention on this track is to use test and the corresponding xtest. See https://github.com/exercism/javascript/blob/main/exercises/practice/leap/leap.spec.js as an example.
There was a problem hiding this comment.
Also would it make sense to use custom exceptions here? Then you don’t need to check both the type and message.
There was a problem hiding this comment.
Any advice and recommendation is good for me, thank you I will look at everything you said
| expect(() => processString('')).toThrow('EmptyStringError'); | ||
| }); | ||
|
|
||
| it('always logs cleanup message', () => { |
There was a problem hiding this comment.
This test checks if a cleanup message is logged after an empty string is provided. That isn’t the same as checking if a cleanup message is always logged.
| @@ -0,0 +1,7 @@ | |||
| export const processString = (input) => { | |||
| //TODO: implement this | |||
| //should throw Error if input is not a string | |||
There was a problem hiding this comment.
This line isn’t correct. The test suite is looking for a specific error type.
| export const processString = (input) => { | ||
| //TODO: implement this | ||
| //should throw Error if input is not a string | ||
| //should throw Error if input is an empty string |
There was a problem hiding this comment.
This implies any Error can be thrown with any message, but that’s not true.
| //TODO: implement this | ||
| //should throw Error if input is not a string | ||
| //should throw Error if input is an empty string | ||
| //should return the uppercase version of the string if valid |
There was a problem hiding this comment.
What’s considered valid here? This line implies by nearness that not all strings are valid, but it’s not clear what is valid.
| //should throw Error if input is not a string | ||
| //should throw Error if input is an empty string | ||
| //should return the uppercase version of the string if valid | ||
| //should use finally to log cleanup message |
Implemented the Error Handling practice exercise with solution, tests, and documentation