Skip to content

Update tests forth #2677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

jagdish-15
Copy link
Contributor

Pull Request

This PR syncs tests.toml with the problem-specifications repository and updates the test file.

Copy link
Contributor

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

Copy link
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@github-actions github-actions bot closed this Jun 14, 2025
@jagdish-15
Copy link
Contributor Author

Additionally, a few test cases in problem-specifications expect the error message "only one value in stack" for certain scenarios. Currently, the implementation uses the same "stack empty" message for both empty stack and single-value stack cases.

Updating this would require changes to the relevant tests and the proof solution implementation. Since it's outside the scope of this PR (which focuses on syncing new tests), I haven't included it here.

If this change makes sense, I'm happy to raise a separate PR to refactor the tests and update the proof accordingly, just let me know.

@SleeplessByte SleeplessByte reopened this Jun 14, 2025
@SleeplessByte
Copy link
Member

Updating this would require changes to the relevant tests and the proof solution implementation. Since it's outside the scope of this PR (which focuses on syncing new tests), I haven't included it here.

It does seem that the sync makes it relevant as it touches for example

description = "division -> errors if there is only one value on the stack"

I wonder why we chose to implement this as stack empty, but it does seem like it should be stack one.

@jagdish-15
Copy link
Contributor Author

Sure, Imma make those changes in the test file and update the proof solution!

@Cool-Katt
Copy link
Contributor

@jagdish-15 That'll be a separate PR or you'll commit to this one?
I'll hold the merge for now, I suppose.

@jagdish-15
Copy link
Contributor Author

@SleeplessByte said that this touches the examples with one value on stack, so I suppose I should commit in this one itself

@SleeplessByte
Copy link
Member

Yeah easier to do it here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants