Skip to content

fix: remove elon #2926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 16, 2025
Merged

fix: remove elon #2926

merged 4 commits into from
Mar 16, 2025

Conversation

vaeng
Copy link
Contributor

@vaeng vaeng commented Mar 12, 2025

Due to recent events, I would like to rename the exercise from Elon to Jedlik.

Ányos Jedlik was the first person to build an electric toy car.

In 1828, the Hungarian priest and physicist Ányos Jedlik invented an early type of electric motor and created a small model car powered by his new motor.

This came from a conversation with @iHiD. I hope raising this PR without being a maintainer of this track is okay.

@iHiD
Copy link
Member

iHiD commented Mar 13, 2025

(@vaeng Just a ping that this is red)

@vaeng
Copy link
Contributor Author

vaeng commented Mar 13, 2025

I do not have the tooling on my machine to check the Java things. The failing checks are surprising, as I merely did (or at least I think) a replace with the two names. Formatting for configlet and linting should be the same. Also I renamed the folder, which makes it extra hard to see the changes online

@kahgoh
Copy link
Member

kahgoh commented Mar 14, 2025

Hey @vaeng, could you please check if you committed with the wrong line endings? The errors from CheckStyle in the CI:


> Task :concept:jedliks-toy-car:checkstyleMain FAILED
[ant:checkstyle] [ERROR] /home/kah/workspace/exercism-java/exercises/concept/jedliks-toy-car/.meta/src/reference/java/JedliksToyCar.java:1: Expected line ending for file is LF(\n), but CRLF(\r\n) is detected. [NewlineAtEndOfFile]

> Task :concept:jedliks-toy-car:checkstyleTest FAILED
[ant:checkstyle] [ERROR] /home/kah/workspace/exercism-java/exercises/concept/jedliks-toy-car/src/test/java/JedliksToyCarTest.java:1: Expected line ending for file is LF(\n), but CRLF(\r\n) is detected. [NewlineAtEndOfFile]

I think you may able to fix the configlet issues with configlet fmt -u -e jedliks-toy-car.

@vaeng
Copy link
Contributor Author

vaeng commented Mar 14, 2025

@kahgoh Thanks, that was it. I used GitHub's online version of Visual Studio Code, which messed up the line endings.

@kahgoh kahgoh merged commit f2720d8 into exercism:main Mar 16, 2025
5 checks passed
@rkabhishek
Copy link
Contributor

Hi, can anyone help understand the point of this change?

It doesn't seem to be an update as the same code passes the updated exercise. So why are we just renaming the exercise?

Also, I think the "gradle-wrapper.jar" is broken as the gradle command was not running. I copied the jar from other exercise and then it worked (The size hints at it; The other exercises have the jar of size 40KB where here it is just 526 Bytes).

@vaeng
Copy link
Contributor Author

vaeng commented Mar 20, 2025

I don't know enough about gradle to check this, but if there is something wrong with this commit, it was not about an update or a fix of the gradle part, so feel free to fix it.

The main intention of this exercise was to rename the exercise to honor one of the inventors of the first electric toy cars instead of Elon.

We did the same at the C# and Go tracks, as these were the only ones where this exercise was implemented with Elon in the name. If you know of more, please notify me so I can act accordingly

@kahgoh
Copy link
Member

kahgoh commented Mar 21, 2025

I think the JAR must have been corrupted during the rename. PR #2932 has been raised to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants