-
-
Notifications
You must be signed in to change notification settings - Fork 44
Add wordy #487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add wordy #487
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with one suggestion to remove one extraneous EOL.
exercises/practice/wordy/wordy.el
Outdated
(provide 'wordy) | ||
;;; wordy.el ends here | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(provide 'wordy) | |
;;; wordy.el ends here | |
(provide 'wordy) | |
;;; wordy.el ends here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an argument to be had about having a named error here. For a difficulty 6 exercise I think it's fine to expect an explicit error "type".
eg.
(signal 'syntax-error)
and
(should-error (answer "What is 1 2 plus?") :type 'syntax-error)
https://www.gnu.org/software/emacs/manual/html_node/elisp/Signaling-Errors.html#index-signal
https://www.gnu.org/software/emacs/manual/html_node/ert/The-should-Macro.html
@keiravillekode Wdyt?
For reference, there's been a of discussion about the errors in this exercise in particular and a larger discussion about the usefulness of input validation. |
For this specific exercise, I have experienced the described frustration. When I ported this exercise to various tracks - arm64-assembly futhark sml vlang - I haven't distinguished between the error cases. Perhaps we could use a single named error like |
c7c3da3
to
42bb199
Compare
@keiravillekode I'll defer to your judgment, but using just one error type seems reasonable and is more friendly to the students. :) Could you please add a comment to the test file that the track is diverging from the canonical test data on purpose and explain the reasoning? It's more visible than in a commit message and will help people later on with maintaining. :) |
Comment added |
No description provided.