Skip to content

Conversation

keiravillekode
Copy link
Contributor

No description provided.

Copy link
Member

@kotp kotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one suggestion to remove one extraneous EOL.

Comment on lines 12 to 14
(provide 'wordy)
;;; wordy.el ends here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(provide 'wordy)
;;; wordy.el ends here
(provide 'wordy)
;;; wordy.el ends here

Copy link
Contributor

@fapdash fapdash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an argument to be had about having a named error here. For a difficulty 6 exercise I think it's fine to expect an explicit error "type".

eg.

(signal 'syntax-error)

and

(should-error (answer "What is 1 2 plus?") :type 'syntax-error)

https://www.gnu.org/software/emacs/manual/html_node/elisp/Signaling-Errors.html#index-signal

https://www.gnu.org/software/emacs/manual/html_node/ert/The-should-Macro.html

@keiravillekode Wdyt?

@fapdash
Copy link
Contributor

fapdash commented Aug 16, 2025

@keiravillekode
Copy link
Contributor Author

For this specific exercise, I have experienced the described frustration.

When I ported this exercise to various tracks - arm64-assembly futhark sml vlang - I haven't distinguished between the error cases.

Perhaps we could use a single named error like 'parse-error

@keiravillekode keiravillekode force-pushed the wordy branch 2 times, most recently from c7c3da3 to 42bb199 Compare August 18, 2025 08:45
@fapdash
Copy link
Contributor

fapdash commented Aug 18, 2025

@keiravillekode I'll defer to your judgment, but using just one error type seems reasonable and is more friendly to the students. :)

Could you please add a comment to the test file that the track is diverging from the canonical test data on purpose and explain the reasoning? It's more visible than in a commit message and will help people later on with maintaining. :)

@keiravillekode
Copy link
Contributor Author

Could you please add a comment

Comment added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants