Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generator: rename template variable #816

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Conversation

ErikSchierboom
Copy link
Member

@ErikSchierboom ErikSchierboom commented Feb 24, 2025

This is done in preparation of changing the order of the generator calls, as we want to keep the :description from the canonical data and not overwrite it. I'm open to naming suggestions.

@tasxatzial
Copy link
Member

So, what's the plan here? Could you give a brief explanation so I have some context? :)

@ErikSchierboom
Copy link
Member Author

Well, previously we overwrote the description property with the value used in the templates that contains the test case's description. As suggested previously, the description property should be set before the callbacks in the generator.clj are called, as that will allow you to update the description in those callbacks. But as some exercises use the description, we can't overwrite its value before that is called.

Copy link
Member

@tasxatzial tasxatzial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I think 'context' is fine, not going to be too picky about naming at this point. If anything comes up, we can update later.

@ErikSchierboom ErikSchierboom merged commit 22a35ff into main Feb 24, 2025
4 checks passed
@ErikSchierboom ErikSchierboom deleted the rename-description branch February 24, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants